Add src and tests #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08xmt
approved these changes
Dec 6, 2023
Comment on lines
+28
to
+56
| function getDbrOut(uint dolaIn) public view returns (uint dbrOut) { | ||
| require(dolaIn > 0, "dolaIn must be positive"); | ||
| (uint dolaReserve, uint dbrReserve) = auction.getCurrentReserves(); | ||
| uint numerator = dolaIn * dbrReserve; | ||
| uint denominator = dolaReserve + dolaIn; | ||
| dbrOut = numerator / denominator; | ||
| } | ||
|
|
||
| function getDolaIn(uint dbrOut) public view returns (uint dolaIn) { | ||
| require(dbrOut > 0, "dbrOut must be positive"); | ||
| (uint dolaReserve, uint dbrReserve) = auction.getCurrentReserves(); | ||
| uint numerator = dbrOut * dolaReserve; | ||
| uint denominator = dbrReserve - dbrOut; | ||
| dolaIn = (numerator / denominator) + 1; | ||
| } | ||
|
|
||
| function swapExactDolaForDbr(uint dolaIn, uint dbrOutMin) external returns (uint dbrOut) { | ||
| dbrOut = getDbrOut(dolaIn); | ||
| require(dbrOut >= dbrOutMin, "dbrOut must be greater than dbrOutMin"); | ||
| dola.transferFrom(msg.sender, address(this), dolaIn); | ||
| auction.buyDBR(dolaIn, dbrOut, msg.sender); | ||
| } | ||
|
|
||
| function swapDolaForExactDbr(uint dbrOut, uint dolaInMax) external returns (uint dolaIn) { | ||
| dolaIn = getDolaIn(dbrOut); | ||
| require(dolaIn <= dolaInMax, "dolaIn must be less than dolaInMax"); | ||
| dola.transferFrom(msg.sender, address(this), dolaIn); | ||
| auction.buyDBR(dolaIn, dbrOut, msg.sender); | ||
| } |
There was a problem hiding this comment.
Would be more gas efficient to have this functionality in the auction itself, to avoid the double transfer, but ultimately not a big deal, as MEV bots can always do the math themselves.
There was a problem hiding this comment.
It would. But also it would prevent us from upgrading the Helper functions in the future. imo we're likely going to create some universal DBR helper in the future that incorporates this virtual market, sDOLA's virtual market and other markets such as TriDBR in a single Router.
|
lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.