Add type hints

Intervention · May 26, 2024 · 81877e6 · 81877e6
1 parent 099f441
commit 81877e6
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/src/Rules/Iban.php b/src/Rules/Iban.php
@@ -142,7 +142,7 @@ public function isValid(mixed $value): bool
      * @param string $iban
      * @return int
      */
-    private function getChecksum(string $iban)
+    private function getChecksum(string $iban): int
     {
         $iban = substr($iban, 4) . substr($iban, 0, 4);
         $iban = str_replace(
@@ -166,9 +166,9 @@ private function getChecksum(string $iban)
      * Returns the designated length of IBAN for given IBAN
      *
      * @param string $iban
-     * @return int
+     * @return int|false
      */
-    private function getDesignatedIbanLength(string $iban)
+    private function getDesignatedIbanLength(string $iban): int|false
     {
         $countrycode = substr($iban, 0, 2);
 

diff --git a/src/Rules/Isbn.php b/src/Rules/Isbn.php
@@ -46,7 +46,7 @@ public function isValid(mixed $value): bool
      * @param string $value
      * @return bool
      */
-    private function shortChecksumMatches(string $value)
+    private function shortChecksumMatches(string $value): bool
     {
         return $this->getShortChecksum($value) % 11 === 0;
     }
@@ -57,7 +57,7 @@ private function shortChecksumMatches(string $value)
      * @param string $value
      * @return int
      */
-    private function getShortChecksum(string $value)
+    private function getShortChecksum(string $value): int
     {
         $checksum = 0;
         $multiplier = 10;

diff --git a/src/Rules/Isin.php b/src/Rules/Isin.php
@@ -57,7 +57,7 @@ public function isValid(mixed $value): bool
      * @param string $value
      * @return string
      */
-    public function normalize(string $value)
+    public function normalize(string $value): string
     {
         return $this->replaceChars($this->getValueWithoutLastDigit($value)) . $this->getLastDigit($value);
     }
@@ -68,7 +68,7 @@ public function normalize(string $value)
      * @param string $value
      * @return string
      */
-    private function replaceChars(string $value)
+    private function replaceChars(string $value): string
     {
         return str_replace($this->chars, array_keys($this->chars), $value);
     }
@@ -79,7 +79,7 @@ private function replaceChars(string $value)
      * @param string $value
      * @return string
      */
-    private function getValueWithoutLastDigit(string $value)
+    private function getValueWithoutLastDigit(string $value): string
     {
         return substr($value, 0, -1);
     }
@@ -90,7 +90,7 @@ private function getValueWithoutLastDigit(string $value)
      * @param string $value
      * @return string
      */
-    private function getLastDigit(string $value)
+    private function getLastDigit(string $value): string
     {
         return substr($value, -1);
     }

diff --git a/src/Rules/Postalcode.php b/src/Rules/Postalcode.php
@@ -14,14 +14,14 @@ class Postalcode extends AbstractRule implements DataAwareRule
      *
      * @var ?string
      */
-    protected $reference;
+    protected ?string $reference;
 
     /**
      * Data set used for validation
      *
      * @var array<string>
      */
-    protected $data = [];
+    protected array $data = [];
 
     /**
      * Create a new rule instance with allowed countrycodes