Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define CDDL via Huddle in shelley-ma #4557

Merged
merged 5 commits into from
Nov 1, 2024
Merged

Define CDDL via Huddle in shelley-ma #4557

merged 5 commits into from
Nov 1, 2024

Conversation

nc6
Copy link
Contributor

@nc6 nc6 commented Aug 21, 2024

Description

Adds CDDL generation via Huddle in both Allegra and Mary eras.

Continues to address #4462

Note that this builds upon #4552 and #4553, which should be reviewed and merged first.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@nc6 nc6 requested a review from lehins August 21, 2024 13:56
@nc6 nc6 changed the title Nc/4462 ma Define CDDL via Huddle in shelley-ma Aug 21, 2024
@aniketd aniketd requested a review from a team as a code owner October 30, 2024 13:08
@lehins
Copy link
Collaborator

lehins commented Oct 30, 2024

These lines need to be removed in cabal files

data-files:
    cddl-files/mary.cddl
-    cddl-files/crypto.cddl
-    cddl-files/extras.cddl

and

data-files:
    cddl-files/allegra.cddl
-    cddl-files/crypto.cddl
-    cddl-files/extras.cddl

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you @nc6 and @aniketd

We use 'here' QuasiQuotes to make handling
multiline comments somewhat less painful.
This addresses issue #4535. The first rule in a
CDDL file is taken to be the root element.
Includes tests and generation utility.
Also includes testing and cddl generation tool.
@lehins lehins enabled auto-merge November 1, 2024 15:42
@lehins lehins merged commit 64833b6 into master Nov 1, 2024
153 of 155 checks passed
@lehins lehins deleted the nc/4462-ma branch November 1, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants