patches: fixed linking to SDL library in map_server #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes linking to
libSDLmain.a
andlibSDL.a
in downstream packages.(with FindSDL.cmake provided by cmake) only sets
SDL_LIBRARY
andSDL_INCLUDE_DIR
(without the trailingS
). Butcatkin_package(DEPENDS <prefix>)
looks for<prefix>_INCLUDE_DIRS
and<prefix>_LIBRARIES
.catkin
emits a warning if neither of both is set for a dependency listed inDEPENDS
, which should actually be treated as an error. Orcatkin
could accept multiple commonly used suffixes for include directories and libraries because apparently there is no standard. See related issue ros/catkin#552.In any case listing
SDL
incatkin_package(DEPS ...)
is equivalent to listing include directories and libraries inINCLUDE_DIRS
andLIBRARIES
argument lists.Another candidate to submit a patch upstream (#81).