[ROS][Test Infra] Support testing ROS2 service call device_info #3124
Conversation
kadiredd
requested review from
deep0294,
SamerKhshiboun and
Arun-Prasad-V
and removed request for
deep0294
| pytest.param(test_params_test_srv_d415, marks=pytest.mark.d415), | ||
| ],indirect=True) | ||
| @pytest.mark.launch(fixture=launch_descr_with_parameters) | ||
| class TestCamera_ServiceCall(pytest_rs_utils.RsTestBaseClass): |
There was a problem hiding this comment.
this test only uses DeviceInfo service call. So, shall we rename this function and file names such that it is specific to DeviceInfo service.
There was a problem hiding this comment.
Yes, thought of it already - There are 8 service calls available. Plan is to have rest seven of them be added here in this file, so no need of changing the file name as of now. And, about changing the function name, yes/maybe -- to be addressed when implementing rest of the service calls. This is kind of placeholder test for validating service calls.
There was a problem hiding this comment.
got it, each test will carry distinct function name and distinct class name as well, right? Modified both class and function names.
kadiredd
force-pushed
the
service_call
branch
4 times, most recently
from
ba85807 to
5c298f7
Compare
We want to add all other services in the same file, Yes. |
SamerKhshiboun
merged commit f8a054c
into
IntelRealSense:ros2-development
Implementation of JIRA ticket req: [LRS-1122]