Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for dpnp.linalg.qr() to run on CUDA #2265

Merged
merged 6 commits into from
Jan 20, 2025
Merged

Workaround for dpnp.linalg.qr() to run on CUDA #2265

merged 6 commits into from
Jan 20, 2025

Conversation

vlad-perevezentsev
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev commented Jan 17, 2025 •
edited
Loading

This PR suggests adding a workaround like waiting for host task after calling geqrf to avoid a race condition due to an issue in oneMath uxlfoundation/oneMath#626

Also updates tests by removing old skips and adds test_qr_large in TestQr

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jan 17, 2025
antonwolfy
antonwolfy approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vlad-perevezentsev

@coveralls
Copy link
Collaborator

coveralls commented Jan 20, 2025 •
edited
Loading

Coverage Status

coverage: 70.844% (-0.006%) from 70.85%
when pulling ef70503 on workaround_qr_cuda
into 9ad1bb5 on master.

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.17.0dev4=py312he4f9c94_13 ran successfully.
Passed: 950
Failed: 0
Skipped: 50

@vlad-perevezentsev vlad-perevezentsev merged commit 807179a into master Jan 20, 2025
45 of 53 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the workaround_qr_cuda branch January 20, 2025 13:40
github-actions bot added a commit that referenced this pull request Jan 20, 2025
@github-actions
Workaround for dpnp.linalg.qr() to run on CUDA (#2265)
b98717e 
This PR suggests adding a workaround like waiting for host task after
calling `geqrf` to avoid a race condition due to an issue in oneMath
uxlfoundation/oneMath#626

Also updates tests by removing old skips and adds `test_qr_large` in
`TestQr` 807179a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlad-perevezentsev @coveralls @antonwolfy