Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove const qualifiers for class/struct members per C++ guidelines #1975

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Remove const qualifiers for class/struct members per C++ guidelines #1975

merged 1 commit into from
Jan 21, 2025

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Further remove const qualifier from struct/class members per C++ guidelines.

The test should be that each such class instance be device copyable. Perhaps static asserts to this effect can be added to the code.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_486 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 88.18%. remained the same
when pulling 936fe68 on further-remove-const-members-of-class-and-structs
into 14a0cf4 on master.

ndgrigorian
ndgrigorian approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Honestly it's fewer than expected

@ndgrigorian ndgrigorian merged commit d9e9bf8 into master Jan 21, 2025
48 of 55 checks passed
@ndgrigorian ndgrigorian deleted the further-remove-const-members-of-class-and-structs branch January 21, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian