Fix build of dpctl with sycl nightly from 2025-01-18 #1974
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure was caused by TwoOffsets_FixedDimStridedIndexer not being device copyable, consequence of not being trivially copyable, consequence of using const class members contrary to C++ coding guidelines.
https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.html
This change adheres to the guidelines by removing const qualifier in class members.
This change also avoids unnecessary copy in constructors of fixed-dim-strided-indexers that take container arguments by values.