Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINT] Pin conda-build to most recent working version #1973

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[MAINT] Pin conda-build to most recent working version #1973

merged 1 commit into from
Jan 17, 2025

Conversation

ndgrigorian
Copy link
Collaborator

Works around known issues with lief in the latest versions of conda-build

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian
Pin conda-build to most recent working version
9663c63 
Works around issues with lief that cause failures after build completes with the message
```
AttributeError: module 'lief._lief.ELF' has no attribute 'ELF_CLASS'
```
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_472 ran successfully.
Passed: 893
Failed: 3
Skipped: 118

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.734%. remained the same
when pulling 9663c63 on pin-conda-build-version-in-ci
into bcef07a on master.

@oleksandr-pavlyk
Copy link
Collaborator

This change had worked 👍

@ndgrigorian ndgrigorian marked this pull request as ready for review January 16, 2025 23:32
@ndgrigorian ndgrigorian merged commit a7e85a2 into master Jan 17, 2025
62 of 63 checks passed
@ndgrigorian ndgrigorian deleted the pin-conda-build-version-in-ci branch January 17, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

@antonwolfy antonwolfy Awaiting requested review from antonwolfy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @oleksandr-pavlyk