Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid copy in triul ctor host task #1960

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Avoid copy in triul ctor host task #1960

merged 2 commits into from
Jan 11, 2025

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Add missing includes to triul_ctor.cpp. Use std::move to move vector of shared pointers into lambda function executed by host_task for lifetime management of temporaries.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Use capture initialization to avoid unnecessary copy of vector of sha…
e3f7439 
…red_ptr

Since the vector is no longer used after it is captured by the lambda submitted
via cgh.host_task, it should be moved rather than copied for efficiency.
@oleksandr-pavlyk
Add missing includes, comment which enties include is for
a873743
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_427 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.715%. remained the same
when pulling a873743 on avoid-copy-in-triul-ctor-host-task
into 9f8f90b on master.

ndgrigorian
ndgrigorian approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oleksandr-pavlyk oleksandr-pavlyk merged commit 1ced1a7 into master Jan 11, 2025
64 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the avoid-copy-in-triul-ctor-host-task branch January 11, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian