Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selective PyTest workflow on Github actions #146

Merged
merged 42 commits into from
Mar 12, 2024
Merged

Selective PyTest workflow on Github actions #146

merged 42 commits into from
Mar 12, 2024

Conversation

laserkelvin
Copy link
Collaborator

This PR creates workflows for selectively running PyTest based on contents of pull requests.

The idea is that certain tests are only based on changes in submodules, i.e. we only run dataset related tests if datasets are changed, etc.

Not entirely sure about performance right now, but it uses micromamba to create and cache environments based on the conda.yml in the root folder.

@laserkelvin
refactor: removing obsolete imports from collate test
b9e5e81
@laserkelvin
test: marking pyg and dgl tests
f09f865
@laserkelvin
refactor: removing obsolete imports from multi dataset
e92025b 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
test: added lmdb marker
fe0dc09 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
refactor: changing mp marks to general remote request decorator
18bb39d
@laserkelvin
refactor: using generalized remote_request in nomad
00a1a07 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
refactor: using remote_request decorator in oqmd
cde16dc
@laserkelvin
refactor: using OQMD devset method instead of passing string path
eab22ad
@laserkelvin
refactor: adding slow marker for dgl dpp
e5aed67
@laserkelvin
refactor: removing redundant dgl dpp test and modernizing dgl init
3f40073 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
refactor: adding distributed mark for test skips
e0241bd 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
refactor: modernizing ddp module
5aacdc6 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
refactor: adding distributed check before running tests
79ecaa2 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
refactor: adding ddp module to import to ensure lightning registration
0fe0bec 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
refactor: modernizing data module exports
881edc9 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
docs: updating contributing information on pytest marks
1b9b882 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
ci: adding mamba based pytest ci action
e6f892b 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
ci: adding mamba based pytest action for models
9bec106 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
ci: adding mamba based pytest action for lightning changes
996ea1c 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin laserkelvin added the code maintenance Issue/PR for refactors, code clean up, etc. label Mar 12, 2024
@laserkelvin laserkelvin requested a review from melo-gonzo March 12, 2024 17:11
@laserkelvin
test: adding manually requested pytest on all files
3e2f34c 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
fix: corrected job name and indentation
e4ff7db 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
fix: corrected job name and indentation for models
3e97e8e 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
fix: corrected indentation for datasets test
7e5a2b4 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
ci: adding environment builder workflow
ce26892 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
refactor: renaming env creation CI workflow
6aed14b 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
ci: making env workflow reusable
e933e55 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
revamping dataset test
20bb9dd 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
revamping lightning pytest
e891710 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
revamped model tests
86c916d 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
ci: adding pytest as part of environment build
c640425 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
ci: make environment build on all pull requests
4946571 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
fix: missing platform specification and pytest install
1a94c00 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
ci: making pytest jobs depend on environment creation
b50d709 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
ci: missing checkout action
1e9e0b2 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
ci: reverting to independent environments for each workflow
2d35423 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
fix: missing mamba activate step
b3f8912 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
fix: micromamba not mamba
b225f0e 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
fix: using micromamba shell for dataset as test
930f11f 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
ci: using checkout version 4 instead of 3
8438d5e 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
fix: setting micromamba shell for lightning tests
484499f 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
fix: setting micromamba shell for model tests
73a6f52 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
@laserkelvin
fix: using micromamba shell for manual all tests
d05401c 
Signed-off-by: Kin Long Kelvin Lee <[email protected]>
melo-gonzo
melo-gonzo approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@melo-gonzo melo-gonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic

@laserkelvin laserkelvin merged commit 6c5743a into IntelLabs:main Mar 12, 2024
0 of 4 checks passed
@laserkelvin laserkelvin deleted the ci-actions-pytest branch March 12, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melo-gonzo melo-gonzo melo-gonzo approved these changes

Assignees
No one assigned
Labels
code maintenance Issue/PR for refactors, code clean up, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laserkelvin @melo-gonzo