helper functions for working with PKPDsim models #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roninsightrx
approved these changes
Jun 10, 2024
|
|
||
| #' Get AUC compartment | ||
| #' @rdname get_model_info | ||
| #' @returns get_model_auc_compartment: returns the index of the final |
There was a problem hiding this comment.
yeah, at some point we should fix that and make a dedicated auc option or so. We shouldn't rely on this assumption. Fine for now.
| #' @returns get_model_structure: returns a single string indicating model | ||
| #' structure. E.g.,: "1cmt_iv", "2cmt_oral". | ||
| #' @export | ||
| get_model_structure <- function(model) attr(model, "misc")[["model_type"]] |
There was a problem hiding this comment.
should we keep same naming as the original attribute, i.e. get_model_type ?
There was a problem hiding this comment.
i considered it but it seemed so generic. i thought "structure" was clearer, since "linearity" could also be considered a type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of information about a model is hidden within its attributes, which are cumbersome to access via
attrorattributes.By wrapping
attrcalls for typical fields we access into functions, this information is made more accessible and better documented.