Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RXR-1953 modify function to calculate parameters to allow computation over time #93

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

roninsightrx
Copy link
Contributor

@roninsightrx roninsightrx commented Mar 25, 2024

The convenience function calculate_parameters() is intended to quickly calculate the effective parameters for a given model and covariates. However, some models have time-varying parameter definitions. To allow computations of effective parameters over time, I've now added a t_obs argument, which then returns each parameter as a vector of values instead of a single value.

I have also added a regimen argument (optional). Because some models may have dose-dependent parameter definitions (although usually a bad idea). Previously, just a dummy "0" dose was used to allow computations to be done in PKPDsim. Now, the regimen can also be specified instead.

@roninsightrx roninsightrx requested a review from jasmineirx March 25, 2024 19:36
Copy link
Contributor

@jasmineirx jasmineirx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. very clearly written tests.

@roninsightrx roninsightrx merged commit 66bb556 into master Mar 25, 2024
2 checks passed
@roninsightrx roninsightrx deleted the RXR-1953 branch March 25, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants