RXR-2224: fix indexing issue iov bins #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the failure of CI for pkgdown is due to the bug described here. I'm not gonna spend time trying to figure out a workaround, will just try to see if it passes next week once all CRAN servers are up-to-date. Update 12/21: issue seems fixed now, build is passing. |
roninsightrx
commented
Dec 20, 2024
| @@ -20,7 +20,7 @@ jobs: | |||
| env: | |||
| GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }} | |||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - uses: actions/checkout@v4 | |||
There was a problem hiding this comment.
unrelated, but they have a newer version of the script available. We're using it in the other action already.
| @@ -11,7 +11,7 @@ Authors@R: c( | |||
| person("Jordan", "Brooks", email = "[email protected]", role = "aut"), | |||
| person("InsightRX", role = c("cph", "fnd"))) | |||
| Depends: R (>= 4.0.0) | |||
| Imports: Rcpp (>= 0.12.9), BH, data.table, stringr, MASS, | |||
| Imports: Rcpp (>= 1.0.13), BH, data.table, stringr, MASS, | |||
There was a problem hiding this comment.
unrelated, saw that we hadn't updated this version requirement (we did in LinkingTo)
mccarthy-m-g
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was creating an array that was unneccessarily large due to a typo.
With this update, the behavior is only harmless when the requested number of bins is lower then the number of bins that were originally defined for the model. However, if the number of requested iov bins is higher than defined for the model, it would lead to a runtime error at the C++ level, since it would try to use a vector element that is not defined.
I have changed the behavior now to throw a warning for the harmless case, and an error (at the R level) for the problematic case. Have updated documentation as well. No C++ level errors should occur anymore.