fix: delete deprecated dateOfBirth()

Informatievlaanderen · May 27, 2024 · 4d1f75c · 4d1f75c
1 parent 870aec2
commit 4d1f75c
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 18 deletions.
diff --git a/...s/src/main/java/be/vlaanderen/vip/magda/client/domain/giveperson/MagdaResponsePerson.java b/...s/src/main/java/be/vlaanderen/vip/magda/client/domain/giveperson/MagdaResponsePerson.java
@@ -124,14 +124,6 @@ public NodeDetailedRelatedPerson(Node node) {
             super(node);
         }
 
-        @Override
-        public LocalDate dateOfBirth() {
-            return node.get("Geboorte/Datum")
-                    .flatMap(Node::getValue)
-                    .map(LocalDate::parse)
-                    .orElse(null);
-        }
-
         @Override
         public IncompleteDate incompleteDateOfBirth() {
             return node.get("Geboorte/Datum")

diff --git a/interfaces/src/main/java/be/vlaanderen/vip/magda/client/domain/giveperson/Person.java b/interfaces/src/main/java/be/vlaanderen/vip/magda/client/domain/giveperson/Person.java
@@ -86,15 +86,6 @@ interface RelatedPerson {
      */
     interface DetailedRelatedPerson extends RelatedPerson {
 
-        /**
-         * The person's date of birth.
-         *
-         * @throws java.time.format.DateTimeParseException in case it's an incomplete date.
-         * @deprecated since this date is possibly incomplete, use {@link #incompleteDateOfBirth()} and call {@link IncompleteDate#toLocalDate()} to extract the actual date. Make sure to handle the {@link IncompleteDateMissingPartException} that may be thrown by that.
-         */
-        @Deprecated(forRemoval = true)
-        LocalDate dateOfBirth();
-
         /**
          * The person's (potentially incomplete) date of birth.
          */

diff --git a/...laanderen/vip/mock/magda/client/domain/giveperson/MagdaResponsePersonIntegrationTest.java b/...laanderen/vip/mock/magda/client/domain/giveperson/MagdaResponsePersonIntegrationTest.java
@@ -55,7 +55,7 @@ void mapsLastName() {
 
         @Test
         void mapsDateOfBirth() {
-            assertThat(self.dateOfBirth(), is(equalTo(LocalDate.of(2000, 12, 20))));
+            assertThat(self.incompleteDateOfBirth().toLocalDate(), is(equalTo(LocalDate.of(2000, 12, 20))));
         }
 
         @Test
-Original file line number
+Diff line change
@@ Expand Up / @@ -55,7 +55,7 @@ void mapsLastName() { @@
             @Test
             void mapsDateOfBirth() {
-                assertThat(self.dateOfBirth(), is(equalTo(LocalDate.of(2000, 12, 20))));
+                assertThat(self.incompleteDateOfBirth().toLocalDate(), is(equalTo(LocalDate.of(2000, 12, 20))));
             }
             @Test
@@ Expand Down @@