refactor: Remove core dependency #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeWeidmann
force-pushed
the
login-refactor
branch
from
a87ff01
to
837a43f
Compare
PhilippeWeidmann
force-pushed
the
login-refactor
branch
from
9e34ff1
to
66dee23
Compare
adrien-coye
reviewed
Jan 15, 2024
There was a problem hiding this comment.
I did a quick review, I have not finished, will tomorrow morning.
I agree with fighting responsability spreading in general, here the idea was to keep our core-ios with the least dependencies possible.
If there exists a need to decouple more auth and core, we can probably abstract some more if we have the time. I would argue this is orthogonal of having login as a dependency of core.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code was brought back from core to prevent interlocking dependencies and responsability spreading.
This is a breaking change, core analog PR is here Infomaniak/ios-core#92