Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove unused code and fix the presentation #1595

Merged
merged 3 commits into from
Oct 29, 2024
Merged

fix: Remove unused code and fix the presentation #1595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4790a6
fix: Remove unused code and fix the presentation
Matthieu-dgl Oct 28, 2024
bf8196e
refactor: Remove unused code
Matthieu-dgl Oct 28, 2024
5331da4
refactor: Revert changes
Matthieu-dgl Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions Mail/Views/Settings/SettingsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ struct SettingsView: View {
@AppStorage(UserDefaults.shared.key(.threadMode)) private var threadMode = DefaultPreferences.threadMode
@AppStorage(UserDefaults.shared.key(.autoAdvance)) private var autoAdvance = DefaultPreferences.autoAdvance

@State private var isShowingSyncProfile = false

var body: some View {
ScrollView {
VStack(alignment: .leading, spacing: 0) {
Expand Down Expand Up @@ -224,9 +222,6 @@ struct SettingsView: View {
.onChange(of: threadMode) { _ in
accountManager.updateConversationSettings()
}
.sheet(isPresented: $isShowingSyncProfile) {
SyncProfileNavigationView()
}
.background(MailResourcesAsset.backgroundColor.swiftUIColor)
.navigationBarTitle(MailResourcesStrings.Localizable.settingsTitle, displayMode: .inline)
.backButtonDisplayMode(.minimal)
Expand Down
2 changes: 1 addition & 1 deletion Mail/Views/SplitView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ struct SplitView: View {
openURL(settingsUrl)
}
}
.sheet(isPresented: $mainViewState.isShowingSyncProfile) {
.fullScreenCover(isPresented: $mainViewState.isShowingSyncProfile) {
SyncProfileNavigationView()
}
.sheet(item: $mainViewState.settingsViewConfig,
Expand Down
Loading