Organizedlines refactor #391
Conversation
| // These placeholders are utilized when pieces are added or pawns promote! | ||
| const extraUndefineds = 5; // After this many promotions, need to add more undefineds and recalc the model! | ||
|
|
||
| class PooledArray<T> extends Array<T|undefined> { |
There was a problem hiding this comment.
Overlaps with gamefileutility's TypeList type. That script has a few organized piece types, I wasn't sure where else to put them, since this script was still in javascript, but I do think it's best for our types to be defined in here.
Also, Only the pieces organized by type object has undefined placeholders for each array. I think the pieces organized by lines should get their own type.
And, since this uses a class, I want to benchmark this later to see if there's a noticeable difference in performance when loading very large games.
EDIT: Actually since PooledArrays are initialized empty, I don't think there'd be a performance change, I however may prefer a normal intersection type over a class.
| } | ||
| } | ||
|
|
||
| interface OrganizedPieces { |
There was a problem hiding this comment.
Overlaps with gamefileutility's PiecesByType type.
There was a problem hiding this comment.
The main branch does not have gamefileutility converted to ts. Should this be merging with gameloader?
There was a problem hiding this comment.
The main branch does not have gamefileutility converted to ts. Should this be merging with gameloader?
Oh sorry, I missed that >_< sometimes when I switch up what I'm working on I just forget on what branch I made specific changes. Yeah I'd merge it with game-loader then! It is the furthest ahead too, since I merged your move piece changes.
| [line: LineKey]: Array<Piece> | ||
| } | ||
|
|
||
| interface Position { |
There was a problem hiding this comment.
Overlaps with gamefileutility's PiecesByKey type.
Convert organized lines to typescript and remove all gui functions from it.