Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatteryIcon: fix set color when using color on low battery #2208

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ljahn
Copy link

@ljahn ljahn commented Dec 23, 2024

As it currently is, the BatteryIcon can change to orange for low battery (if selected at creation).
However, the code assumes the default color to be white. In my Star Trek watch face, the default Icon color is black.

This change makes it such that when recharging after getting orange (or even red) the icon returns to the color set by SetColor.

Also adds a convenience function to set the visibility of the icon.

Copy link

Build size and comparison to main:

Section Size Difference
text 372832B 16B
data 948B 0B
bss 22536B 0B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant