Adjust build instructions #2203
Conversation
`cd build` before `cmake` seems to cause issues, as does a cmake command with insufficient details. Finally, many end users and developers will want to OTA flash their firmware, so handy DFU instructions in the correct folder might be appreciated.
mark9064
added
maintenance
| make -j4 pinetime-app | ||
| ``` | ||
|
|
||
| However if you want to flash the firmware OTA using an app like Gadgetbridge, using *pinetime-mcuboot-app* will create the `pinetime-mcuboot-app-dfu-$VERSION.zip` file you want in the `build/src` folder. |
There was a problem hiding this comment.
This is a great addition. Maybe modify the above L84 to specify "PineTime devkit"? Currently these instructions kind of assume a devkit, whereas I think a lot of people work on sealed now as the bootloader is very stable
| ``` | ||
| cmake -DARM_NONE_EABI_TOOLCHAIN_PATH=... -DNRF5_SDK_PATH=... | ||
| cmake -S "." -B "build" -DCMAKE_BUILD_TYPE=Release -DARM_NONE_EABI_TOOLCHAIN_PATH=... -DNRF5_SDK_PATH=.. -DBUILD_DFU=1 -DBUILD_RESOURCES=1 -DNRF_TARGET=nrf52 |
There was a problem hiding this comment.
-DNRF_TARGET=nrf52 isn't needed, it's already specified in the cmake file. Release is also the default type, so I don't think that needs to be specified either (it's listed above, and I think people who need debug will know when they need it, you have to be pretty involved at that point)
As for DFU/resources, how about giving two example commands, one which builds neither (as current) and one which builds both, I think that way users can easily get the idea of what the options do
cd buildbeforecmakeseems to cause issues, as does a cmake command with insufficient details. Finally, many end users and developers will want to OTA flash their firmware, so handy DFU instructions in the correct folder might be appreciated.