Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/link-and-eslint-sort-plugin #8

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

birobirobiro
Copy link
Contributor

@birobirobiro birobirobiro commented Aug 1, 2024

Nessa PR eu instalei essas duas libs pra facilitar e padronizar mais as coisas

  • @tabler/icons-react
  • eslint-plugin-simple-import-sort

E também adicionei o link do repositório na Navbar

image

@wellwelwel
Copy link
Contributor

wellwelwel commented Aug 1, 2024

Na instalação de dependências está acusando que o @tabler/icons-react requer o React 18 e a gente está usando o 19, vou tentar testar aqui 😕

@wellwelwel
Copy link
Contributor

@birobirobiro, consegue adicionar a flag --force nesses dois comandos?

Testei localmente e funcionou certinho 🙋🏻‍♂️

package.json Show resolved Hide resolved
@@ -32,7 +35,8 @@ export default function NavBar() {
{ label: 'criadores', href: '/criadores' },
{ label: 'projetos', href: '/projetos' },
{ label: 'ideias', href: '/ideias' },
{ label: 'sobre', href: '/sobre' }
{ label: 'sobre', href: '/sobre' },
{ href: 'https://github.com/Indie-Hackers-Brasil/website', icon: <IconBrandGithub /> }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não seria melhor adicionarmos as redes sociais no Footer?

Para mantermos a consistência no design!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sim, faz mais sentido! Mas precisaria estar estruturado o footer, como pensa no layout dele?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants