-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/link-and-eslint-sort-plugin #8
base: main
Are you sure you want to change the base?
feat/link-and-eslint-sort-plugin #8
Conversation
Na instalação de dependências está acusando que o |
@birobirobiro, consegue adicionar a flag website/.github/workflows/ci_build.yml Line 34 in f57ce9a
website/.github/workflows/ci_lint.yml Line 34 in f57ce9a
Testei localmente e funcionou certinho 🙋🏻♂️ |
src/components/navbar.tsx
Outdated
@@ -32,7 +35,8 @@ export default function NavBar() { | |||
{ label: 'criadores', href: '/criadores' }, | |||
{ label: 'projetos', href: '/projetos' }, | |||
{ label: 'ideias', href: '/ideias' }, | |||
{ label: 'sobre', href: '/sobre' } | |||
{ label: 'sobre', href: '/sobre' }, | |||
{ href: 'https://github.com/Indie-Hackers-Brasil/website', icon: <IconBrandGithub /> } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Não seria melhor adicionarmos as redes sociais no Footer?
Para mantermos a consistência no design!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sim, faz mais sentido! Mas precisaria estar estruturado o footer, como pensa no layout dele?
Nessa PR eu instalei essas duas libs pra facilitar e padronizar mais as coisas
E também adicionei o link do repositório na Navbar