ci: add selene as a linter #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2024
Merged
Merge activity
You must have a Graphite account in order to use the merge queue. Create an account and try again using this link
|
AliSajidImami
previously approved these changes
Oct 20, 2024
AliSajid
force-pushed
the
10-19-docs_update_the_readme.md_
branch
from
5417210
to
30562ad
Compare
AliSajid
force-pushed
the
10-19-ci_add_selene_as_a_linter
branch
from
5b4cfd8
to
2ae7c6b
Compare
AliSajid
changed the base branch from
10-19-docs_update_the_readme.md_
to
main
AliSajid
force-pushed
the
10-19-ci_add_selene_as_a_linter
branch
from
2ae7c6b
to
88591ff
Compare
AliSajidImami
previously approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added Selene Lua linter to pre-commit hooks and configured it for Vim/Neovim development.
What changed?
.pre-commit-config.yamlto include Selene as a local hookselene.tomlconfiguration file to set the Vim standardvim.tomlto define Vim-specific globals and functions for SeleneHow to test?
cargo install selenepre-commit run --all-filesWhy make this change?
Integrating Selene as a Lua linter improves code quality and consistency in Vim/Neovim plugin development. It helps catch potential errors and enforces best practices specific to the Vim environment.