Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armv7-build-fix #90

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Armv7-build-fix #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion images/wkdev_sdk/Containerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ ENV RUSTUP_HOME="/opt/rust" \
CARGO_HOME="/opt/rust" \
PATH="/opt/rust/bin:${PATH}"

RUN rustup default stable && \
RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove rustup from images/wkdev_sdk/required_system_packages/04-devtools.lst.

For arguments we prefer the full names rather than abbreviated versions so its more readable.

rustup default stable && \
rustup component remove rust-docs && \
cargo install --root /usr/local --version 0.8.1 --locked sccache && \
cargo install --root /usr/local cargo-c
Expand Down
2 changes: 2 additions & 0 deletions images/wkdev_sdk/required_system_packages/05-armv7-jhbuild.lst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Needed for jhbuild on armv7
libyaml-dev desktop-file-utils
Loading