BaseItemList: Emit events before and after adding the list item to the list #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviks789
force-pushed
the
feature/baseitemlist-on-item-add-event
branch
from
879fcfd
to
bf18d3a
Compare
raviks789
force-pushed
the
feature/baseitemlist-on-item-add-event
branch
4 times, most recently
from
b99b3d4
to
62f5119
Compare
raviks789
changed the title
ON_ITEM_ADD event after adding the list item to the list
raviks789
force-pushed
the
feature/baseitemlist-on-item-add-event
branch
from
62f5119
to
0e02d30
Compare
nilmerg
requested changes
May 28, 2024
raviks789
force-pushed
the
feature/baseitemlist-on-item-add-event
branch
from
ae3398e
to
dc51003
Compare
nilmerg
approved these changes
May 28, 2024
nilmerg
added a commit
to Icinga/icinga-notifications-web
that referenced
this pull request
May 31, 2024
resolves #132 Blocked by: #155, #166 requires: Icinga/ipl-web#217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be helpful if lists could perform additional tasks before and after a list item is added to it. Hence the events
BEFORE_ITEM_ADDandON_ITEM_ADDwould be desirable.