Link: Allow to optionally enable modal view #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabteab
force-pushed
the
modal-opener
branch
from
1bec467
to
e0413df
Compare
nilmerg
requested changes
Sep 8, 2023
There was a problem hiding this comment.
I'd rather create a trait and use that in the Link class. The trait allows the user to optionally make the link a modal opener and since Link is the base for ActionLink and ButtonLink the same applies to them.
The reason for this is, that the javascript implementation for modals expect the opener to be an anchor with a href attribute. A plain button wouldn't work as href isn't a valid attribute for it.
So the only way to not have a link act as opener, but a button, is stylewise, and that's what ButtonLink is for.
The trait should have a public method openInModal(): self and applies the appropriate attributes there.
yhabteab
force-pushed
the
modal-opener
branch
from
e0413df
to
b11a32a
Compare
yhabteab
changed the title
ModalOpener
nilmerg
reviewed
Sep 8, 2023
yhabteab
force-pushed
the
modal-opener
branch
from
b11a32a
to
bb2c5f7
Compare
yhabteab
force-pushed
the
modal-opener
branch
from
bb2c5f7
to
c5b57b5
Compare
nilmerg
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.