Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TermInput.js: Encode and quote terms, not the other way round #177

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Aug 1, 2023

Any separator which needs to be encoded, won't be detected and thus no unnecessary quoting happens. If, on the other hand, the quoting is necessary due to an unencoded separator, the quotes are not encoded, as the server doesn't expect or need this.

Any separator which needs to be encoded, won't be detected
and thus no unnecessary quoting happens. If, on the other
hand, the quoting is necessary due to an unencoded separator,
the quotes are not encoded, as the server doesn't expect or
need this.
@nilmerg nilmerg added the bug Something isn't working label Aug 1, 2023
@nilmerg nilmerg added this to the v0.9.0 milestone Aug 1, 2023
@nilmerg nilmerg self-assigned this Aug 1, 2023
@cla-bot cla-bot bot added the cla/signed label Aug 1, 2023
@nilmerg nilmerg merged commit 975d262 into main Aug 1, 2023
6 of 12 checks passed
@nilmerg nilmerg deleted the fix/term-quoting branch August 1, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant