Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Style element to create dynamic inline styles #202

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Use Style element to create dynamic inline styles #202

merged 1 commit into from
Sep 1, 2023

Conversation

yhabteab
Copy link
Member

@cla-bot cla-bot bot added the cla/signed label Aug 16, 2023
@yhabteab yhabteab self-assigned this Aug 16, 2023
@yhabteab yhabteab added enhancement New feature or improvement and removed cla/signed labels Aug 16, 2023
@yhabteab yhabteab added this to the 1.3.0 milestone Aug 16, 2023
@cla-bot cla-bot bot added the cla/signed label Aug 17, 2023
sukhwinder33445
sukhwinder33445 reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style::addInlineStyleFor() is now Style::addFor().

sukhwinder33445
sukhwinder33445 requested changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the param type hints and phpDoc changes to phpstan branch.

library/X509/ExpirationWidget.php Outdated Show resolved Hide resolved
library/X509/ExpirationWidget.php Outdated Show resolved Hide resolved
sukhwinder33445
sukhwinder33445 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@sukhwinder33445 sukhwinder33445 merged commit 7cf61f5 into main Sep 1, 2023
@sukhwinder33445 sukhwinder33445 deleted the csp branch September 1, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg left review comments

@sukhwinder33445 sukhwinder33445 sukhwinder33445 approved these changes

Assignees

@yhabteab yhabteab

Labels
cla/signed enhancement New feature or improvement
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

CSP Compliancy
3 participants
@yhabteab @nilmerg @sukhwinder33445