Only qualify base columns during quick searches #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
added
bug
All other columns are already qualified relative to the base model. This is usually sufficient because qualification is only required if applied to a query, which isn't happening at this stage. fixes #979
nilmerg
force-pushed
the
fix/tactical-overview-omits-hosts-without-service-979
branch
from
c61000c to
d5fc900
Compare
nilmerg
deleted the
fix/tactical-overview-omits-hosts-without-service-979
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other columns are already qualified relative to the base model. This is usually sufficient because qualification is only required if applied to a query, which isn't happening at this stage.
fixes #979