Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ITL vmware-esx-soap-host-net{,-nic}: Add missing option "--unplugged_nics_state" #10261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ITL vmware-esx-soap-host-net{,-nic}: Add missing option "--unplugged_nics_state" #10261

wants to merge 1 commit into from

Conversation

n-rodriguez
Copy link

Hi there!

Add missing option --unplugged_nics_state to vmware-esx-soap-host-net and vmware-esx-soap-host-net-nic.

It's a revival of #8618, hope it will be merged 😃

Thank you!

@cla-bot cla-bot
Copy link

cla-bot bot commented Nov 30, 2024

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @n-rodriguez

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@n-rodriguez n-rodriguez force-pushed the wip/unplugged_nics_state branch from 205d20d to bdab782 Compare November 30, 2024 02:02
@cla-bot cla-bot
Copy link

cla-bot bot commented Nov 30, 2024

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @n-rodriguez

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@n-rodriguez
Copy link
Author

CLA is signed

@bobapple
Copy link
Member

bobapple commented Dec 2, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Dec 2, 2024
@oxzi oxzi changed the title Add missing option "--unplugged_nics_state" ITL vmware-esx-soap-host-net{,-nic}: Add missing option "--unplugged_nics_state" Dec 2, 2024
@oxzi oxzi added the area/itl Template Library CheckCommands label Dec 2, 2024
oxzi
oxzi reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution!

Please address the one change I have commented. Otherwise, it looks good to me.

itl/plugins-contrib.d/vmware.conf Outdated Show resolved Hide resolved
@n-rodriguez n-rodriguez force-pushed the wip/unplugged_nics_state branch from bdab782 to bbde6fa Compare December 2, 2024 16:22
@n-rodriguez
Copy link
Author

Please address the one change I have commented. Otherwise, it looks good to me.

@oxzi done!

oxzi
oxzi approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your contribution. Looks good to me!

oxzi
oxzi reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, since you are a new contributor, there is one more thing you need to do. Please add yourself to the AUTHORS file at the correct alphabetical position. Please apologize that I forgot to mention this before.

oxzi

This comment was marked as off-topic.

Sign in to view

oxzi
oxzi requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@oxzi oxzi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please excuse the mess with the multiple comments.. I just wanted to change the status to requested changes, but GitHub had other plans for me. Thus, please address my previous comment: #10261 (review)

@n-rodriguez n-rodriguez force-pushed the wip/unplugged_nics_state branch from bbde6fa to e881898 Compare December 3, 2024 14:23
@n-rodriguez
Copy link
Author

@oxzi done!

oxzi
oxzi approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again.

@n-rodriguez
Copy link
Author

Hi there! Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxzi oxzi oxzi approved these changes

Assignees

@Al2Klimov Al2Klimov

Labels
area/itl Template Library CheckCommands cla/signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@n-rodriguez @bobapple @oxzi @Al2Klimov