-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IcingaCheckTask: Add available I/O cpu semaphores as a perfdata #10248
base: master
Are you sure you want to change the base?
Conversation
729bafd
to
a323bb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Don't we duplicate everything in check_icinga and our CIB, so that it can be queried via API?
@@ -85,6 +85,11 @@ boost::asio::io_context& IoEngine::GetIoContext() | |||
return m_IoContext; | |||
} | |||
|
|||
int_fast32_t IoEngine::GetCpuSemaphore() const | |||
{ | |||
return m_CpuBoundSemaphore; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julianbrost Also, I'm wondering whether we can do this:
return m_CpuBoundSemaphore; | |
return m_CpuBoundSemaphore.load(std::memory_order_relaxed); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to for easier debugging purposes.