IcingaDB Check: Multiple Responsible Instances #10188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al2Klimov
previously approved these changes
Nov 14, 2024
oxzi
force-pushed
the
icingadb-heartbeat-both-responsible
branch
from
0e45b0c to
b4e1066
Compare
Al2Klimov
approved these changes
Nov 15, 2024
|
I don't think producing a check output counts as logging, thus you might want to rephrase your commit message and PR title. |
oxzi
force-pushed
the
icingadb-heartbeat-both-responsible
branch
from
b4e1066 to
f57d074
Compare
oxzi
changed the title
|
@yhabteab: You are totally right. The old description was in deed misleading and a bit flippant. Please take another look. |
By design, only one Icinga 2 instance should be responsible in the HA context. If this promise is broken, the Icinga 2 IcingaDB check should report it. The code did not check for invalid data in icingadb:telemetry:heartbeat. With this change, it will go CRITICAL with a descriptive message and report the actual number of icingadb_responsible_instances in the performance data.
oxzi
force-pushed
the
icingadb-heartbeat-both-responsible
branch
from
f57d074 to
0bbe7a9
Compare
|
I have just rebased this branch on the |
yhabteab
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By design, only one Icinga 2 instance should be responsible in the HA context. If this promise is broken, the Icinga 2 IcingaDB check should report it.
The code did not check for invalid data in
icingadb:telemetry:heartbeat. With this change, it will go CRITICAL with a descriptive message and report the actual number oficingadb_responsible_instancesin the performance data.ref/IP/55850