-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Query builder #17
base: main
Are you sure you want to change the base?
Conversation
13775df
to
9cfb220
Compare
I would find it clearer if the API did not require the query builder to be created again and again. It would also be more flexible if the different statement types were separate structs. |
If we're starting to discuss the overall API design this PR won't do it to get Icinga/icinga-notifications#114 merged any time soon. So either we merge this as an experimental API (i.e. might fundamentally change) or we need another PR that simply exposes a |
I see. Then let’s just merge it. |
I've asked for this to be done nonetheless as I find the current interface this PR adds more confusing than it needs to be in regards to what it accepts in |
f7e58d9
to
62b871b
Compare
62b871b
to
295535f
Compare
resolves #57
refs #16 (2a133da is cherry-picked from that PR)