Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline publishing process #83

Conversation

bisgaard-itis
Copy link
Collaborator

@bisgaard-itis bisgaard-itis commented Nov 2, 2023

What do these changes do?

  • Ensure client version comes from a VERSION file in clients/python/client.
  • Add a make recipe which will generate a VERSION file. The version generated has the format <latest released version>+<number of commits from latest released commits>. This ensures every new pushed commit can be published on TestPypi with a unique version number. I have tested that packaging.version.Version behaves properly with respect to this type of versioning. E.g. Version("3.2.6+15")>Version("3.2.6+14") evaluates to True while Version("3.2.6+15")>Version("3.2.7+14") evaluates to False.
  • Update the github workflow so it generates a correct VERSION file if the workflow is triggered by a tagged commit (=release) and every new commits on master is published to TestPypi.
  • Clean up release workflow. Now releasing a client is done entirely through Github. Simply tag a commit with a tag of the type v3.2.4.

Related issue/s

How to test

For internal developers

@bisgaard-itis bisgaard-itis added the enhancement New feature or request label Nov 2, 2023
@bisgaard-itis bisgaard-itis added this to the Microhistory milestone Nov 2, 2023
@bisgaard-itis bisgaard-itis self-assigned this Nov 2, 2023
@bisgaard-itis bisgaard-itis marked this pull request as ready for review November 2, 2023 11:04
.github/workflows/publish-python-client.yml Outdated Show resolved Hide resolved
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thx!

@bisgaard-itis bisgaard-itis merged commit 014a394 into ITISFoundation:master Nov 3, 2023
8 checks passed
@bisgaard-itis bisgaard-itis deleted the streamline-publishing-process branch November 3, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants