-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline publishing process #83
Merged
bisgaard-itis
merged 39 commits into
ITISFoundation:master
from
bisgaard-itis:streamline-publishing-process
Nov 3, 2023
Merged
Streamline publishing process #83
bisgaard-itis
merged 39 commits into
ITISFoundation:master
from
bisgaard-itis:streamline-publishing-process
Nov 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvangeit
approved these changes
Nov 2, 2023
wvangeit
requested changes
Nov 2, 2023
pcrespov
reviewed
Nov 2, 2023
wvangeit
approved these changes
Nov 3, 2023
pcrespov
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 thx!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
VERSION
file inclients/python/client
.VERSION
file. The version generated has the format<latest released version>+<number of commits from latest released commits>
. This ensures every new pushed commit can be published on TestPypi with a unique version number. I have tested thatpackaging.version.Version
behaves properly with respect to this type of versioning. E.g.Version("3.2.6+15")>Version("3.2.6+14")
evaluates toTrue
whileVersion("3.2.6+15")>Version("3.2.7+14")
evaluates toFalse
.VERSION
file if the workflow is triggered by a tagged commit (=release) and every new commits on master is published to TestPypi.v3.2.4
.Related issue/s
How to test
For internal developers