Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix e2e tests #210

Merged
merged 1 commit into from
Nov 13, 2024
Merged

🐛 Fix e2e tests #210

merged 1 commit into from
Nov 13, 2024

Conversation

bisgaard-itis
Copy link
Collaborator

@bisgaard-itis bisgaard-itis commented Nov 12, 2024 •
edited
Loading

What do these changes do?

  • An update in the gihub action we use to publish osparc to Pypi seems to have broken our pipeline. So the last prelrelease packages were not pushed to pypi. The issue seems to be the new attestation feature (see here and here)
  • I also filter for the osparc version when checking RAM usage for file upload/download since this feature was only added recently.

Related issue/s

How to test

For internal developers

@bisgaard-itis bisgaard-itis self-assigned this Nov 12, 2024
@bisgaard-itis bisgaard-itis added the bug Something isn't working label Nov 12, 2024
@bisgaard-itis bisgaard-itis added this to the Event Horizon milestone Nov 12, 2024
matusdrobuliak66
matusdrobuliak66 approved these changes Nov 12, 2024
View reviewed changes
Copy link

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sanderegg
sanderegg approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

pcrespov
pcrespov approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

.github/workflows/publish-python-client.yml Show resolved Hide resolved
clients/python/test/e2e/test_files_api.py Show resolved Hide resolved
@bisgaard-itis bisgaard-itis merged commit fe4f50c into ITISFoundation:master Nov 13, 2024
8 checks passed
@bisgaard-itis bisgaard-itis deleted the 209-disable-gh-attestation-and-limit-tests branch November 13, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov pcrespov approved these changes

Assignees

@bisgaard-itis bisgaard-itis

Labels
bug Something isn't working
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.

Disable github workflow attestation and restrict tests
4 participants
@bisgaard-itis @pcrespov @sanderegg @matusdrobuliak66