Skip to content

Commit

Permalink
🐛 minor fix (#91)
Browse files Browse the repository at this point in the history
* update workflow before publishing python package

* fix dependency issue and bump version

* point to website in project description

* fix broken dependency

* improve doc

* add github token to download artifacts

* ensure only read-access @wvangeit

* yet another attempt at downloading artifacts

* make sure to use repo that ran the trigger wf

* another attempt at fixing

* change owner

* allow publishing to testpypi also when pr

* minor change

* revert minor (but breaking) change

* minor fix
  • Loading branch information
bisgaard-itis authored Nov 3, 2023
1 parent 9579a50 commit 696ebcb
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions .github/workflows/publish-python-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ permissions: read-all
jobs:
publish-osparc_client:
name: Publish osparc_client wheel
if: ${{ github.event.workflow_run.conclusion == 'success' }}
if: github.event.workflow_run.conclusion == 'success' && github.event.workflow_run.event.event_name == 'push'
runs-on: ubuntu-latest
environment:
name: pypi
Expand All @@ -29,22 +29,21 @@ jobs:
osparc_wheel=$(ls osparc_python_wheels/osparc-*)
rm -f ${osparc_wheel}
- name: Publish osparc_client to Test PyPI
if: github.event_name == 'push' || github.event_name == 'pull_request'
uses: pypa/gh-action-pypi-publish@release/v1
with:
repository-url: https://test.pypi.org/legacy/
verbose: true
packages-dir: osparc_python_wheels/
- name: Publish osparc_client to PyPI
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
if: startsWith(github.ref, 'refs/tags')
uses: pypa/gh-action-pypi-publish@release/v1
with:
verbose: true
packages-dir: osparc_python_wheels/

publish-osparc:
name: Publish osparc wheel
if: ${{ github.event.workflow_run.conclusion == 'success' }}
if: github.event.workflow_run.conclusion == 'success' && github.event.workflow_run.event.event_name == 'push'
runs-on: ubuntu-latest
environment:
name: pypi
Expand All @@ -63,14 +62,14 @@ jobs:
osparc_client_wheel=$(ls osparc_python_wheels/osparc_client*)
rm -f ${osparc_client_wheel}
- name: Publish osparc to Test PyPI
if: github.event_name == 'push' || github.event_name == 'pull_request'
if: github.event_name == 'pull_request'
uses: pypa/gh-action-pypi-publish@release/v1
with:
repository-url: https://test.pypi.org/legacy/
verbose: true
packages-dir: osparc_python_wheels/
- name: Publish osparc to PyPI
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
if: startsWith(github.ref, 'refs/tags')
uses: pypa/gh-action-pypi-publish@release/v1
with:
verbose: true
Expand Down

0 comments on commit 696ebcb

Please sign in to comment.