Update from upstream #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <[email protected]>
This is deprecated in php8 Ref https://php.watch/versions/8.0/deprecate-required-param-after-optional Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
…ub.com/ChristophWurst/Imap_Client into ChristophWurst-fix/php8.1-tentative-return-type-horde
…b.com/ChristophWurst/Imap_Client into ChristophWurst-fix/magic-serialize-unserialize-horde
- maintain usage of json encoding to save cache storage where possible
- remove associative arrays in favor of numerically indexed arrays
when serializing.
After reviewing performance on newer PHP versions it doesn't appear that this optimization is worth it, and could in fact perform worse.
Signed-off-by: Christoph Wurst <[email protected]>
…ache does not revive on unserialize.
…__serialize() and Cannot redeclare Horde_Imap_Client_Cache_Backend_Cache::__serialize()
Apple's iCloud IMAP server (and possibly others, although I haven't tested it) want brackets around any FLAG command params as shown in the examples of [RFC3501](https://datatracker.ietf.org/doc/html/rfc3501#section-6.4.6]) If the brackets aren't added, the command fails with BAD Parse Error To fix this, wrap the params of a STORE command in a Horde_Imap_Client_Data_Format_List Otherwise, the \Delete FLAG, \Seen FLAG and possibly all other PERMFLAGs aren't added, even if the STORE command doesn't return a BAD response. Signed-off-by: Anna Larch <[email protected]>
fix: STORE for iCloud and other strict IMAP servers
Fix Fatal errors : Cannot redeclare Horde_Imap_Client_Cache_Backend::…
Fix undefined index 'count' (FRAMEWORK_6_0)
Fix Mailbox testBadInput test on PHP 8.2 (Bytestream #23 for FRAMEWORK_6_0)
removed duplicate __serialize and __unserialize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.