IQSS/11142 show replace in file differences #11145
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: On the file page, the version table did not show when one file replaced another (it just showed No changes associated with this version. Now it shows:
Which issue(s) this PR closes:
Special notes for your reviewer: The fix for this was rather trivial, just turning on existing functionality by adding a details=true flag. However, in fixing that I discovered:
dataverse/src/main/webapp/file-versions.xhtml
Line 45 in 6d6a509
dataverse/src/main/webapp/file-versions.xhtml
Line 53 in 6d6a509
dataverse/src/main/webapp/file-versions.xhtml
Line 44 in 6d6a509
Suggestions on how to test this:
Create/publish a dataset with a file, replace the file, verify that the file page version table notes the change.
Add a free-form provenance note to the file, check that the save succeeds/the dataset page is still viewable, etc. (allowing free-form provenance is a flag that may need to be set on the test machine).
Does this PR introduce a user interface change? If mockups are available, please link/include them here: In the old table, a file that was replaced, and had a description change just shows as
Is there a release notes update needed for this change?: included.
Additional documentation: