Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent DOCS_AND_FREQS_AND_POSITIONS Solr error #11140

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Jan 8, 2025

What this PR does / why we need it:

This PR updates the release note added for #10887 to prevent a strange "DOCS_AND_FREQS_AND_POSITIONS" error we observed switching to the Solr schema.xml in that PR.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Two ways:

Try to reproduce #11139 on a classic installation where we've kept the Solr index (internal or beta, maybe?). [edit: not internal - I erased the old index there before reindexing - L.A.]

In a Docker environment run code prior to #10887 (consider running the search tests with mvn test -Dtest=SearchIT). Then pull the latest to pick up #10887, upgrade your schema with cp conf/solr/schema.xml docker-dev-volumes/solr/data/data/collection1/conf/schema.xml, and then try to reproduce #11139.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes update needed for this change?:

Yes, this PR updates release notes.

Additional documentation:

None.

@pdurbin pdurbin added Size: 3 A percentage of a sprint. 2.1 hours. FY25 Sprint 14 FY25 Sprint 14 (2025-01-02 - 2025-01-15) labels Jan 8, 2025
@qqmyers
Copy link
Member

qqmyers commented Jan 8, 2025

W.r.t. release notes, hopefully the Solr 9.7.0 update gets into 6.6 which would avoid people having to do this?

@pdurbin
Copy link
Member Author

pdurbin commented Jan 8, 2025

@qqmyers I had that thought. Yes, that will also fix it. But I also wanted to write down the bug and fix. Definitely if we tell people to upgrade to a new version of Solr we won't need the extra steps in this PR.

@vera
Copy link
Contributor

vera commented Jan 9, 2025

Good addition. I can confirm that emptying the Solr index before reloading the schema fixes that error message.

@landreev
Copy link
Contributor

landreev commented Jan 9, 2025

on a classic installation where we've kept the Solr index (internal or beta, maybe?)

On internal I ended up erasing the index and reindexing from scratch.

```shell
curl "http://localhost:8983/solr/admin/cores?action=RELOAD&core=collection1"
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above will work just fine.
But it may be even simpler to tell them to clear the existing index before updating the schema (in step 7., before stopping solr). Since changing the schema requires stopping and restarting, no need to reload the core as a separate step.

Just a thought - up to you; not a big deal either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 14 FY25 Sprint 14 (2025-01-02 - 2025-01-15) Size: 3 A percentage of a sprint. 2.1 hours.
Projects
Status: Ready for QA ⏩
Development

Successfully merging this pull request may close these issues.

After PR#10887, you must clear the Solr index and reload the core (DOCS_AND_FREQS_AND_POSITIONS error)
4 participants