ENH Rework bagging notebook #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
reviewed
Oct 17, 2024
python_scripts/ensemble_bagging.py
Outdated
| @@ -127,6 +124,7 @@ def bootstrap_sample(data, target): | |||
| data_bootstrap, target_bootstrap = bootstrap_sample( | |||
| data_train, | |||
| target_train, | |||
| seed=bootstrap_idx, | |||
There was a problem hiding this comment.
I might add a small comment to mention that since we pass different seed, we ensure that the bootstrap samples are different but reproducible.
glemaitre
approved these changes
Oct 17, 2024
ArturoAmorQ
commented
Oct 17, 2024
github-actions bot
pushed a commit
to kalona/scikit-learn-mooc
that referenced
this pull request
Nov 2, 2024
github-actions bot
pushed a commit
to scgupta/scikit-learn-mooc
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #763 (comment), we should avoid showing a pattern where people would use the random number generator across different function and estimators. This PR fixes the issue and takes the opportunity to rework the general wording.