ENH Improve wording in stratification notebook #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
changed the title
glemaitre
reviewed
Apr 26, 2024
| # | ||
| # In conclusion, it is a good practice to use stratification within the | ||
| # cross-validation framework when dealing with a classification problem, | ||
| # especially for datasets with imbalanced classes or when the class distribution |
There was a problem hiding this comment.
I am not really sure of the conclusion. To me, I'm thinking more about the following two aspects:
- if target labels are ordered or grouped, then stratification allows to overcome this issue if you forget to shuffle as in the k-fold case;
- if the sample size is limited or small (and data are shuffled), then taking a stratified fold ensure similar train/test distribution compare to the uniform sampling.
And thus overcoming the both above issues make that the evaluation is closer to reality.
There was a problem hiding this comment.
I am not entirely convinced on the rewording I made, but I think I addressed your points in 42c9775
Co-authored-by: Guillaume Lemaitre <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
May 17, 2024
Co-authored-by: ArturoAmorQ <[email protected]> Co-authored-by: Guillaume Lemaitre <[email protected]> ca7d1d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a formation at Inria Academy we noticed that this notebook never really justifies why stratification is important. This PR adds a couple of paragraphs to better motivate the reason why a simple
KFoldwith shuffling is not a good enough practice.It also takes the opportunity to implement verbs in present mode and improve general wording.
NB. I think this PR is safe to merge at it does not change the overall experience of the mooc.