Merge branch 'main' into debug-pr-preview-part-3

INRIA · Oct 30, 2023 · 298a74a · 298a74a
2 parents 3c4237d + f39b464
commit 298a74a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/deploy-gh-pages.yml b/.github/workflows/deploy-gh-pages.yml
@@ -44,6 +44,8 @@ jobs:
           v2-refs/heads/main
 
     - name: Build the JupyterBook
+      env:
+        GITHUB_PULL_REQUEST_NUMBER: ${{github.event.number}}
       run: |
         bash build_tools/build_jupyter_book.sh
 

diff --git a/build_tools/build_jupyter_book.sh b/build_tools/build_jupyter_book.sh
@@ -30,16 +30,18 @@ write_changed_html() {
     if [ -n "$GITHUB_PULL_REQUEST_NUMBER" ]
     then
         GITHUB_PULL_REQUEST_URL="https://github.com/inria/scikit-learn-mooc/pull/$GITHUB_PULL_REQUEST_NUMBER"
-        echo "The following files may have been changed by PR $GITHUB_PR_NUMBER:"
+        echo "The following files may have been changed by PR $GITHUB_PULL_REQUEST_NUMBER:"
         echo "$affected"
         (
             echo '<html><body>'
-            echo 'Files changed by PR <a href="'"$GITHUB_PR_URL"'">'"$GITHUB_PR_URL</a>"
+            echo "Files changed by PR <a href=\"$GITHUB_PULL_REQUEST_URL\">$GITHUB_PULL_REQUEST_URL</a>"
             echo '<ul>'
             echo "$affected" | sed 's|.*|<li><a href="&">&</a> [<a href="https://inria.github.io/scikit-learn-mooc/&">main</a>]|'
             echo '</ul><p>This PR JupyterBook <a href="index.html">index</a>'
             echo '</ul></body></html>'
         ) > "$jupyter_book_build_dir/_changed.html"
+    else
+        echo "The variable 'GITHUB_PULL_REQUEST_NUMBER' is not defined: not writing the '_changed.html' file."
     fi
 }