Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename portfolio to cluster recovery #569

Merged

Conversation

longshuicy
Copy link
Member

@longshuicy longshuicy commented May 13, 2024

@longshuicy longshuicy changed the title rename and changelog Rename portfolio to cluster recovery May 13, 2024
@longshuicy longshuicy self-assigned this May 13, 2024
@navarroc
Copy link
Member

BuildingClusterRecovery is missing the copyright year, looks like this was missed during the original review.

@longshuicy
Copy link
Member Author

BuildingClusterRecovery is missing the copyright year, looks like this was missed during the original review.

I added them. Looking at the git commits, the analysis was added by Indira in 2018 hence I put 2018 as the year. Hope it's ok?

@navarroc
Copy link
Member

BuildingClusterRecovery is missing the copyright year, looks like this was missed during the original review.

I added them. Looking at the git commits, the analysis was added by Indira in 2018 hence I put 2018 as the year. Hope it's ok?

I think that sounds good. Thank you!

Copy link
Member

@ywkim312 ywkim312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test ran good. Approve

@ywkim312 ywkim312 merged commit f3c78de into develop May 24, 2024
7 checks passed
@ywkim312 ywkim312 deleted the 559-rename-portfolio-recovery-to-building-cluster-recovery branch May 24, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename portfolio recovery to building cluster recovery
3 participants