Fixes #171 - removed unnecessary dependency #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
matplotlib removed a deprecated method in 3.9.0 hence the failing pytests. We can either pin to 3.8.4 OR we can change the reference to cm.get_cmap to plt.get_cmap, but I am not sure if that is the best approach. |
ywkim312
approved these changes
Jul 9, 2024
Merged
ylyangtw
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes openssl requirement in setup.py, which pip doesn't have. This prevents pyincore-viz > 1.9.0 from installing because there is no pip openssl library.