-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
295 semantics with dfr3 curves and mapping #297
Open
longshuicy
wants to merge
17
commits into
develop
Choose a base branch
from
295-semantics-with-dfr3-curves-and-mapping
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navarroc
reviewed
Jul 8, 2024
server/dfr3-service/src/main/java/edu/illinois/ncsa/incore/service/dfr3/models/DFR3Set.java
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
longshuicy
changed the title
295 semantics with dfr3 curves and mapping
WIP - 295 semantics with dfr3 curves and mapping
Jul 10, 2024
longshuicy
changed the title
WIP - 295 semantics with dfr3 curves and mapping
295 semantics with dfr3 curves and mapping
Jul 15, 2024
navarroc
reviewed
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Note that fragility curve parameters have special case of
period
andnum_stories
do not need to be a part of the columns; hence excluded in the SemanticsConstants.RESERVED_COLUMNS. There are special logic on pyincore to compute those two fields.To test:
dataType
to["ergo:bridgesVer3", "incore:epfVer2"]
should also pass ✓dataType
should error out ✗ergo:bridgesVer3
] should fail ✗606221fe618178207f6608a1
should fail ✗