10/UI/form/section headings html tags #8889
Draft
+148
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klees
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Hi @catenglaender,
LGTM in general, plain, simple and functional.
- Question 1: Did you check with @yvseiler et al regarding the visuals (indentation etc.).
- Question 2: How will this look on small screens?
- Advice: Please check back with @nhaagen to look into unit tests.
Kind regards!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mantis.ilias.de/view.php?id=42226
Issue
Sections no longer have heading tags.
Changes
Sections now assess their nesting level and html tags are rendered accordingly. I also strengthened the visual difference of differently deep nesting levels.
Advice needed
Unit tests can currently only handle the first level expecting a h2. I will discuss a better solution with my colleagues.