[FEATURE] UI: improve segregation of public and internal interfaces. #8805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibsy
added
kitchen sink
improvement
php
thibsy
force-pushed
the
feature/11/ui-interface-segregation
branch
from
726f6b6 to
c8b2f35
Compare
thibsy
force-pushed
the
feature/11/ui-interface-segregation
branch
from
9ea7adc to
a8073e2
Compare
* Adds documentation about the public and internal interface segregation. * Adds DI for ALL nested UI factories and adds them to `Init\AllModernComponents`. * Changes all UI factory implementations to return concrete implementations rather than the interface. * Removes all necessary PHPDoc annotations of UI factories.
thibsy
force-pushed
the
feature/11/ui-interface-segregation
branch
from
a8073e2 to
c8119a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
This PR may seem huge, because it affects almost all factory implementations and related unit tests, but the actual changes can be summarised to this:
Init\AllModernComponents. There have been several factories which were created dynamically on each call.@inheritDocannotations in order for intelisense to suggest the concrete implementation only. While at it I also removed some other unnecessary comments.What the PR does at its essence: create a clear boundary between public and internal context, so we can start implementing internal components and only expose them internally.
I am happy to discuss this PR with you :).
Kind regards,
@thibsy