Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link tests #79

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Update link tests #79

wants to merge 11 commits into from

Conversation

hadro
Copy link
Contributor

@hadro hadro commented Jan 27, 2023

No description provided.

@hadro
Copy link
Contributor Author

hadro commented Jan 27, 2023

This is to finally update the link tests to a more modern version of html-proofer, 4.4.3.
This required re-rewriting many of the opts for the link checker, and the biggest change is that they've dropped HTML validation altogether, claiming that browsers are very good at figuring out intent and correcting errors, and that this caused needless errors. If we want to enforce HTML validation still, we'll have to do it another way.

}
HTMLProofer.check_directory(SITE_DIR, opts).run
end
# desc 'Check for *iiif.io* link errors'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this test doing that is not covered by either the internal link checker, or the external link checker?

@glenrobson
Copy link
Member

Hi Josh,

I'm just looking into this and I've got a few questions:

  • How are you updating the version of HTML proofer? I can't see the version in the Gemfile but I can see it in the website version...
  • I can't seem to find version 4.4.3 on https://github.com/gjtorikian/html-proofer/releases
  • Where do you see the HTML validation being removed?

Thanks

@hadro
Copy link
Contributor Author

hadro commented Feb 1, 2023

@hadro
Copy link
Contributor Author

hadro commented Feb 1, 2023

From the upgrade link above: The biggest change is that the HTML parsing check has been removed. HTML parsers like Nokogumbo/Nokogiri, and indeed, many browsers, are fairly generous when it comes to accepting malformed HTML. This feature detected more false issues than actual ones.

@glenrobson
Copy link
Member

Possible html5 checker: https://pypi.org/project/html5validator/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants