Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transformer for Glide. #2

Merged
merged 10 commits into from
Jan 12, 2025
Merged

Add transformer for Glide. #2

merged 10 commits into from
Jan 12, 2025

Conversation

Rup-Narayan-Rajbanshi
Copy link
Contributor

Changes

  • Add transformation for glide.

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as ready for review January 7, 2025 11:27
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/add-transformation-for-glide branch from 1eecf62 to 8ea4a6b Compare January 7, 2025 11:31
@emmanuelmathot
Copy link
Collaborator

I just added the test and STAC validation for the Glide transformer output.
@Rup-Narayan-Rajbanshi Please not That I change the GlideTransformer data to be a single GlideDataSource. glide API out is always a single glideset, right?

I keep working on the adjustment to have valid STAC items

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/add-transformation-for-glide branch 3 times, most recently from f773832 to 7898dfa Compare January 8, 2025 08:36
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/add-transformation-for-glide branch from 7898dfa to 8575373 Compare January 8, 2025 12:06
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/add-transformation-for-glide branch from c81d2ee to ad5da24 Compare January 10, 2025 04:16
emmanuelmathot
emmanuelmathot approved these changes Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@emmanuelmathot emmanuelmathot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR because as it is sufficient for now. I removed the glide hazard check because there is no added value in the information

@emmanuelmathot emmanuelmathot merged commit 0c75039 into main Jan 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelmathot emmanuelmathot emmanuelmathot approved these changes

@ranjan-stha ranjan-stha Awaiting requested review from ranjan-stha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rup-Narayan-Rajbanshi @emmanuelmathot @ranjan-stha