Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create version of bioformats2raw that can be used for converting IDR studies #1

Merged
merged 4 commits into from
Jun 19, 2023

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Feb 14, 2023

See IDR/deployment#389 for the context

This PR contains the minimal changes to evaluate the conversion of historical IDR studies which rely on a proprietary fork of OME Bio-Formats.

@dominikl
Copy link
Member

Could we merge and release an "IDR bioformats2raw"? And maybe even push to conda? Would make it much easier setting up an NGFF conversion environment. Now we have to always say "Go to this PR, get the zip from the artifacts (which even disappears again a certain number of days)... etc."

@will-moore
Copy link
Member

I can't actually see where to download the artifacts?
Under the Successful runs above I see The logs for this run have expired and are no longer available.
Is there where the artifacts would be?
Which build would I want? 8, 11 or 17?

@dominikl
Copy link
Member

I think @sbesson has to close and re-open the PR so that they get built again.

@sbesson
Copy link
Member Author

sbesson commented Jun 15, 2023

I can certainly push another commit for the latest IDR Bio-Formats fixes which should be released in prod116 which should trigger another artifact build via GitHub Actions.

If we need some form of persistency, we can certainly merge this in and create a tag (either 0.x.0 or including a suffix to avoid confusion with the upstream bioformats2raw releases) to generate a bundle of the converter as a GitHub release asset.

@will-moore
Copy link
Member

@sbesson sounds great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants