bugfix: we must count the actual number of cuda devices #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we have an API in PaRSEC that returns the number of devices for a given type? |
QingleiCao
reviewed
Jan 22, 2024
abouteiller
force-pushed
the
bugfix/dtd_gpu
branch
from
ebb6d83
to
bf8e3b2
Compare
|
I reworked the PR after discovering that we were already doing the device counting in testing/common.c both points raised still stand, as the existing code could use the proposed API that count devices of a particular type, and the code handles only CUDA indeed |
abouteiller
force-pushed
the
bugfix/dtd_gpu
branch
from
bf8e3b2
to
0919f7a
Compare
initialized/not initialized differently than the -g param Signed-off-by: Aurelien Bouteiller <[email protected]>
abouteiller
force-pushed
the
bugfix/dtd_gpu
branch
from
0919f7a
to
e31ffc5
Compare
|
|
I propose we move forward with this as-is to fix the buggy behavior, and integrate with the query interface in a separate PR when it has been merged in parsec. |
devreal
approved these changes
Jan 31, 2024
This was referenced Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to decide if we need to register (or not) the gpu workspaces